Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

which branch to use? UTF issue still alive #8

Closed
whitas opened this issue Jun 28, 2018 · 4 comments
Closed

which branch to use? UTF issue still alive #8

whitas opened this issue Jun 28, 2018 · 4 comments

Comments

@whitas
Copy link

whitas commented Jun 28, 2018

Hi all

Which branch to use ;) ? Is develop most up to date? Will all changes merged to master someday?

In both develop and master I have still UTF issue

Garmin Connect activity: [2806957153] Maszyna eliptyczna
	Wt, 26 cze 2018 17:38, 	Downloading file... Traceback (most recent call last):
  File "/Users/tomek/Garmin/garmin-connect-export//gcexport3.py", line 371, in <module>
    write_to_file(data_filename, data.decode(), file_mode)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xdc in position 12: invalid continuation byte

@whitas whitas changed the title which branch to use? which branch to use? UTF issue still alive Jun 28, 2018
@pe-st
Copy link
Owner

pe-st commented Jul 3, 2018

Hello @whitas

The Python 3 script (gcexport3.py) is the same in the develop and master branches; for the time being I just keep them for comparison purposes.

My own development happens in the Python 2 script (gcexport.py) on the develop branch. There are some things I want to implement yet before consolidating the two scripts.

Is the UTF-8 issue also present with gcexport.py?

@pe-st
Copy link
Owner

pe-st commented Jul 6, 2018

Hello @whitas

I've added some notes about branches and forks in the README to make clear that in this repo here only the Python 2 version of the script is maintained (and I removed gcexport3.py in my repo).
So the question about the branch is answered and I'm closing the issue.

For the UTF issue: this is still a duplicate of moderation/garmin-connect-export#14

@pe-st pe-st closed this as completed Jul 6, 2018
@whitas
Copy link
Author

whitas commented Jul 6, 2018

Hi. I don't know if UTF-8 issue also present with gcexport.py because there is HTTP404 issue and script fails to download anything.

@whitas
Copy link
Author

whitas commented Jul 6, 2018

Oh.. sorry this 404 issue is from the second repo "moderation" as well as UTF8. It's just a bit confusing me with git that I'm not fully aware which repo and which branch from repo I'm using.

Anyway - gcexport.py from here is working ok now for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants