Allow absolute paths for publish_dir #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 58.09% 57.61% -0.48%
==========================================
Files 4 4
Lines 241 243 +2
Branches 43 45 +2
==========================================
Hits 140 140
- Misses 101 103 +2
Continue to review full report at Codecov.
|
|
The v3.6.4 has been released and the v3 tag has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your great work. I have a use case where the tool to find the generated documentation is returning an absolute path. Instead of trying to calculate the relative paths by myself, I feel we can support absolute paths instead. This seems to be an easy change so I just made a PR. Please feel free to commit any further changes to this branch. This will close #242.