Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "Invalid value 'ready' labels.Status: Ready.labeled.pr.action" #568

Open
4 tasks done
Andre601 opened this issue Jun 7, 2022 · 4 comments
Open
4 tasks done
Assignees
Labels
bug Something isn't working

Comments

@Andre601
Copy link
Contributor

Andre601 commented Jun 7, 2022

Checklist

  • I am using the latest version of this action.
  • I have read the latest README and followed the instructions.
  • I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.
  • I have set RUNNER_DEBUG: 1 for debugging.

Describe the bug

Currently, use this action to mark a PR as Draft or ready depending on the labels added/removed.

When I was using it today, I noticed that while the action does comment on the PR, did it not change the PR's state to Ready.
Checking the latest examples and docs here, I saw that draft: true changed to action: ready, so I tried this now, but the action now failed with the message Invalid value "ready" labels.Status: Ready.labeled.pr.action despite this being 1:1 the same in the label-commenter-config.yml file:

pr:
body: Thank you for following the template. The repository owner will review this.
action: ready

Yes, I am using a dedicated User account here and the account has sufficient permissions to change a PR's state. This action worked before but now doesn't.

Relevant links

YAML config: https://github.com/Readme-Workflows/recent-activity/blob/main/.github/label-commenter-config.yml
YAML workflow: https://github.com/Readme-Workflows/recent-activity/blob/main/.github/workflows/pr_comment.yml

Relevant log output

Run peaceiris/actions-label-commenter@v1.10.0
  with:
    github_token: ***
    config_file: .github/label-commenter-config.yml
[INFO] Version 1.10.0
[INFO] Usage https://github.com/peaceiris/actions-label-commenter#readme
[INFO] event name: pull_request
[INFO] config file path: .github/label-commenter-config.yml
[INFO] label name: Status: Ready
[INFO] label event: labeled
[INFO] issue number: 193
[INFO] no configuration labels.Status: Ready.labeled.pr.locking
[INFO] comment URL: https://github.com/Readme-Workflows/recent-activity/pull/193#issuecomment-1148791343
Error: Action failed with error "invalid value "ready" labels.Status: Ready.labeled.pr.action"

Additional context.

As mentioned above did this action work perfectly fine before and PRs were marked as Ready or Draft.
The example file on this repository mentions action: draft and action: ready for PRs so someone would guess it's actually what you need to mark a PR properly, but the fact that it fails means that there must be an issue.

@Andre601 Andre601 added the bug Something isn't working label Jun 7, 2022
@Andre601
Copy link
Contributor Author

Andre601 commented Jun 7, 2022

Also, to add to this: I previously used draft: true yet this didn't work either which made me update the configuration file.

@peaceiris
Copy link
Owner

It just has not been released.

@Andre601
Copy link
Contributor Author

Sorry for such a late reply: What is the solution now? draft: true|false (As I used before) doesn't seem to work anymore, as mentioned in my previous comment.

@Andre601
Copy link
Contributor Author

Okay.

I've updated the action to use draft: true|false again, but the problem is, that the PR isn't updated. It remains a Draft or Ready even tho the action should do the opposite.

The latest workflow run where this happens (Debug was enabled): https://github.com/Readme-Workflows/recent-activity/runs/8293723349?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants