Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task queue blocks on too many wildcard operations #12

Closed
bartek-siudeja opened this issue Jan 30, 2019 · 3 comments
Closed

Task queue blocks on too many wildcard operations #12

bartek-siudeja opened this issue Jan 30, 2019 · 3 comments
Assignees
Milestone

Comments

@bartek-siudeja
Copy link

Let me start by saying that s5cmd is a big improvement over aws and s3cmd. And wildcard support is by far the best feature of s5cmd.

However, it seems that s5cmd (release v0.6.0) is getting stuck when many wildcard commands are submitted using a file or stdin. As soon as number of wildcard (batch) operations is equal to or larger than numworkers nothing is actually downloaded. It looks like all workers are busy handling wildcards, waiting for actual put/get operations to finish. But there are no workers available to perform put/get operations.

This would not be a problem if number of workers could be set arbitrarily high. And technically it can. But we found out that on say i3.2 AWS instance (8 vCPUs) download speed is significantly reduced with 256 workers, compared to 16 or 32 workers. One can get around this by submitting listing commands in one file, then making a long list of non-batch operations in another file.

@ilkinulas ilkinulas added the bug label Feb 4, 2019
@ilkinulas
Copy link
Member

Thank you very much for the feedback. We will look into it.

@igungor
Copy link
Member

igungor commented Feb 24, 2020

Duplicate #58

Let's keep both open.

@ilkinulas ilkinulas added this to the v1.0.0 milestone Mar 2, 2020
@sonmezonur
Copy link
Member

Hi @bartek-siudeja. We fixed the bug and released v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants