Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Glacier warnings #346

Closed
sonmezonur opened this issue Aug 24, 2021 · 1 comment · Fixed by #404
Closed

Ignore Glacier warnings #346

sonmezonur opened this issue Aug 24, 2021 · 1 comment · Fixed by #404
Labels
feature-request question
Milestone
v2.0.0

Comments

@sonmezonur
Copy link
Member

After 9defce6, commands have started to return exit status 1 if glacier warnings are encountered during execution. It is a breaking change for users who use version v1.3.0. I think it would be useful to add a flag for turning on/off glacier warnings similar to (--ignore-glacier-warnings)). As default, commands should exit with 0 for glacier warnings if we don't wanna break current API (v1.3.0).
@igungor
Copy link
Member

igungor commented Aug 24, 2021

Agreed.

@igungor igungor added this to the v2.0.0 milestone Sep 21, 2021
@sonmezonur sonmezonur mentioned this issue Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request question
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

command: return non-zero exit code for errors and add ignore-glacier-warnings option peak/s5cmd
2 participants
@igungor @sonmezonur