Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootDse() does not use in-memory cache #8

Open
alecpl opened this issue Feb 8, 2023 · 1 comment
Open

rootDse() does not use in-memory cache #8

alecpl opened this issue Feb 8, 2023 · 1 comment

Comments

@alecpl
Copy link

alecpl commented Feb 8, 2023

Looks to me that true || here needs to be removed:

if (true || !array_key_exists($attrs_signature, $this->_rootDSE_cache)) {

@hbeni
Copy link
Collaborator

hbeni commented Feb 8, 2023

Like it is now, always a fresh object is fetched.
I don't remember the reason for this, but it may be a left over artifact from development.

From the first glance, I think too that the true should be removed, however this needs rigid testing before changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants