Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate users can be created for the same idp #12

Open
jwise opened this issue Nov 20, 2019 · 1 comment
Open

Duplicate users can be created for the same idp #12

jwise opened this issue Nov 20, 2019 · 1 comment

Comments

@jwise
Copy link
Contributor

jwise commented Nov 20, 2019

If a user hits refresh during a long database stall and kicks off a second user-create (on first login with an idp), two users associated with the same idp could be created (i.e., both instances will check to see if that idp exists, and if a user with that idp exists; both will create a user with that idp; and then both transactions will commit). I can reduce the window in which that intermediate state exists (having both check later to see if someone else has come in), but I do not have the expertise to make that disallowed state not exist at all.

In the mean time, I'm solving this just by cleaning this up by hand...

@mhelmetag
Copy link

Maybe some kind of idempotency cookie/token that then gets sent in the user create request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants