Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Session invalidated on audio stop but reused in results #24

Open
rufferson opened this issue Jun 23, 2016 · 1 comment
Open

Voice Session invalidated on audio stop but reused in results #24

rufferson opened this issue Jun 23, 2016 · 1 comment

Comments

@rufferson
Copy link

Hi,
_handle_stop_transfer invalidates current session when audio stream stops but then it checks it here to use here while sending results. Probably emulator never sends stop, but IRL it matters.
Trivial fix, don't think worth making fork/PR stuff.

@rufferson
Copy link
Author

Oh well it sends stop however reference implementation (transcription_server) has send_result executed from stop callback so it kinda works. But again, if the calls are executed asynchronously and callback does not wait - session gets invalidated prior to response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant