Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app-tools.test.build to test split-path on *nix or windows #31

Merged

Conversation

avescodes
Copy link

Added multi-platform test to stress the changes made in #29.

These tests pass on Mac OS X, but I was unable to get leiningen/clojure/java working on my Windows box, so I defer to @djpowell to lend a hand. If tests run successfully then this also closes #23.

@djpowell
Copy link
Contributor

@rkneufeld yes, that test passes on windows, and fails if I revert the change to build.clj

@djpowell
Copy link
Contributor

(@rkneufeld btw - I have a lein installer for windows here https://bitbucket.org/djpowell/leiningen-win-installer)

@avescodes
Copy link
Author

Very good to know, thanks for pointing that out!

avescodes pushed a commit that referenced this pull request Mar 24, 2013
Add app-tools.test.build to test split-path on *nix or windows
@avescodes avescodes merged commit 28c3beb into pedestal:master Mar 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app-tools.build/split-path probably won't work in Windows
2 participants