This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
fix(docz-theme-default): rename playground container to avoid conflicts #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jared-Dev
reviewed
Oct 29, 2018
| @@ -388,13 +388,13 @@ export class Render extends Component<RenderComponentProps, RenderState> { | |||
|
|
|||
| private transformCode(code: string): string { | |||
| return ` | |||
| const App = ({ children }) => ( | |||
| const _App = ({ children }) => ( | |||
There was a problem hiding this comment.
Suggested change
| const _App = ({ children }) => ( | |
| const _Docz_App = ({ children }) => ( |
What does everyone think about namespacing this so that it is even less likely to collide in the future? Since the user shouldn't need to interact with this directly I can't think of too many negatives to doing this.
| <React.Fragment> | ||
| {children && typeof children === 'function' ? children() : children} | ||
| </React.Fragment> | ||
| ) | ||
|
|
||
| render(<App>${code}</App>) | ||
| render(<_App>${code}</_App>) |
There was a problem hiding this comment.
Suggested change
| render(<_App>${code}</_App>) | |
| render(<_Docz_App>${code}</_Docz_App>) |
There was a problem hiding this comment.
I think that use underscore is something weird, I prefer DoczApp like normal!
There was a problem hiding this comment.
@pedronauck I renamed it do DoczApp
|
Closes #426 |
pedronauck
pushed a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves issue: #426
I renamed playground container to avoid conflicts with components named
App.