Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn packages fail (following contributing guidelines) #706

Closed
ivan-dalmet opened this issue Mar 22, 2019 · 10 comments
Closed

yarn packages fail (following contributing guidelines) #706

ivan-dalmet opened this issue Mar 22, 2019 · 10 comments
Labels

Comments

@ivan-dalmet
Copy link
Contributor

Trying to contribute on the 1.0.0-rc.3 but following the contributing guidelines doesn't work :(

yarn
yarn bs
yarn packages --> fail 😢

Node version: v10.13.0
Yarn version: 1.15.2

@pedronauck
Copy link
Member

Can you show me the error @ivan-dalmet ?

@pedronauck pedronauck added the v1 label Mar 22, 2019
@ivan-dalmet
Copy link
Contributor Author

image

@ivan-dalmet
Copy link
Contributor Author

image

@ivan-dalmet
Copy link
Contributor Author

ivan-dalmet commented Mar 22, 2019

@pedronauck It's a fresh new fork (I removed my old one and started from scratch)

@ivan-dalmet
Copy link
Contributor Author

The problem comes from the snapshots

@Glazy
Copy link
Contributor

Glazy commented Mar 23, 2019

Thanks for filing an issue about this @ivan-dalmet.

I also just experienced this whilst working on the project. The snapshot tests will fail for everyone because the absolute path to an example fixture is stored in the snapshot.

Unless us users are storing docz at the exact same location in our filesystem as @pedronauck then the snapshots will always fail for us. You can work around this by running yarn test -u in other-packages/babel-plugin-export-metadata but make sure you don't commit the updated snapshot with any changes you make 💪

@macklinu
Copy link

I wonder if there's a way to strip out the part of the file path for the tests so that tests can pass on everyone's machine - taking a look to see if I can help out with this.

@pedronauck
Copy link
Member

Oh, my bad 🤔 Thanks @Glazy, I'll check if I can help with this. It's a so much important thing!

@macklinu
Copy link

I did take a look at the test but was unable to come up with a solution (thanks @pedronauck for commenting to remind me to follow up 😂).

@pedronauck
Copy link
Member

Fixed, will be release today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants