-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn packages fail (following contributing guidelines) #706
Comments
Can you show me the error @ivan-dalmet ? |
@pedronauck It's a fresh new fork (I removed my old one and started from scratch) |
The problem comes from the snapshots |
Thanks for filing an issue about this @ivan-dalmet. I also just experienced this whilst working on the project. The snapshot tests will fail for everyone because the absolute path to an example fixture is stored in the snapshot. Unless us users are storing |
I wonder if there's a way to strip out the part of the file path for the tests so that tests can pass on everyone's machine - taking a look to see if I can help out with this. |
Oh, my bad 🤔 Thanks @Glazy, I'll check if I can help with this. It's a so much important thing! |
I did take a look at the test but was unable to come up with a solution (thanks @pedronauck for commenting to remind me to follow up 😂). |
Fixed, will be release today :) |
Trying to contribute on the 1.0.0-rc.3 but following the contributing guidelines doesn't work :(
Node version: v10.13.0
Yarn version: 1.15.2
The text was updated successfully, but these errors were encountered: