This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
fix(docz-theme-default): ensures the overlay is hidden when the sidebar is collapsed #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of [v3.4.0](https://github.com/webpack/webpack-dev-server/releases/tag/v3.4.0) the option "none" is no longer a valid value for webpack-dev-server's clientLogLevel config. webpack/webpack-dev-server#1825
|
Is there any plan to merge this one? |
|
@pepibumur I hope so too. @pedronauck, what are your thoughts about this one? This issue was also mentioned a few days ago in #870 so it appears to be affecting multiple users. I myself am running this commit in production in the interim and haven't had any problems. |
|
This is no longer necessary since the new v2. |
|
sweet, thanks @pedronauck will anything be done about scroll to top on navigation atm? any recommendations for fixing this in user land if we're waiting for v2? |
|
I'll release v2 in the next few days, I think is best to wait until there. It's very close ✌️ |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes issue #850. This bug was also seen in earlier issues (#476, #293).
Perhaps if we merge this pull request then we can have the confidence that the overlay will always be removed when the sidebar is hidden.