Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting file-wide eslint-disable adds star #25

Open
hildjj opened this issue Aug 13, 2022 · 0 comments
Open

Inserting file-wide eslint-disable adds star #25

hildjj opened this issue Aug 13, 2022 · 0 comments

Comments

@hildjj
Copy link
Contributor

hildjj commented Aug 13, 2022

Cmd-. an eslint error, select "Disable @peggyjs/no-unused-rules for the entire file", you get this added to the top of the file:

/** eslint-disable @peggyjs/no-unused-rules */

This doesn't work because of the extra asterisk at the beginning. What is desired is this:

/* eslint-disable @peggyjs/no-unused-rules */

See https://github.com/microsoft/vscode-eslint/blob/1fa8e21b20f83987d349ac500a571194695117a3/server/src/eslintServer.ts#L699 for where the insertion happens. getBlockComment should return [ "/*", "*/" ] as far as I can see, so I don't know why this is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant