Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytecode tests should use constants, rather than magic numbers #81

Closed
StoneCypher opened this issue Apr 19, 2021 · 2 comments
Closed

Bytecode tests should use constants, rather than magic numbers #81

StoneCypher opened this issue Apr 19, 2021 · 2 comments

Comments

@StoneCypher
Copy link
Contributor

@Mingun
Copy link
Member

Mingun commented Apr 19, 2021

Probably, just comments with bytecode names will be enough (as I did in all my syntax extensions in my fork).

Your assumption about bytecode source is right.

@StoneCypher
Copy link
Contributor Author

Well, you're much deeper about this tooling than I am

If you think so, maybe you're right

I'll leave it open for a day in case anyone else has an opinion, and if not, I'll close it and cede to yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants