You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the following example, the 'text' should be 'Arbil, Iraq' but due to the way the outputGenerator is written it matches nothing for local and 'Arbil' for regional (the name is also 'Arbil').
If I simply add admin1 to the end of the local array then both local and regional will match 'Arbil' and when the de-duper removes one entry, we are back with the text being 'Arbil'.
Not sure if I described this well, but basically we need to continue checking values in the local and regional arrays until we find a value which is not a duplicate of the name or another admin value, otherwise a POI with { "name": "a", "local_admin": "a", "admin1_abbr": "a", "admin0": "b" } will always just be a when it would be nicer if it were a, b.
In the following example, the 'text' should be 'Arbil, Iraq' but due to the way the
outputGenerator
is written it matches nothing forlocal
and 'Arbil' forregional
(thename
is also 'Arbil').If I simply add
admin1
to the end of the local array then bothlocal
andregional
will match 'Arbil' and when the de-duper removes one entry, we are back with the text being 'Arbil'.Not sure if I described this well, but basically we need to continue checking values in the
local
andregional
arrays until we find a value which is not a duplicate of the name or another admin value, otherwise a POI with{ "name": "a", "local_admin": "a", "admin1_abbr": "a", "admin0": "b" }
will always just bea
when it would be nicer if it werea, b
.Hope that makes sense ;)
The text was updated successfully, but these errors were encountered: