Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update allowed list of layers for Geonames #569

Closed
orangejulius opened this issue Jun 29, 2016 · 2 comments
Closed

Update allowed list of layers for Geonames #569

orangejulius opened this issue Jun 29, 2016 · 2 comments
Assignees
Labels

Comments

@orangejulius
Copy link
Member

orangejulius commented Jun 29, 2016

The list of allowed layers for Geonames is out of date. Over time we've added better layer mappings to the Geonames importer, but haven't kept the API list up to date.

We need to ensure that every layer that a Geonames record can be is listed in the API. I think we have to add macroregion and localadmin, but there may be more.

Compare these two queries to see the issue. The first one searches Geonames for Detroit, and the second result is of type localadmin. The second query searches Geonames for only localadmin records, but it returns an error saying no such records exist (they obviously do)

http://pelias.github.io/compare/#/v1/search%3Fsources=gn&size=2&text=detroit,%20mi
screenshot from 2016-06-29 15-03-54
screenshot from 2016-06-29 15-04-06

http://pelias.github.io/compare/#/v1/search%3Fsources=gn&layers=localadmin&size=2&text=detroit,%20mi
screenshot from 2016-06-29 15-03-16

Related to #484 (and could probably be done at the same time)

@orangejulius
Copy link
Member Author

Oh also, as in #484, we need to ensure the documentation is up to date.

@orangejulius
Copy link
Member Author

Acceptance tests would be good to add as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants