New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to fully test email sending #59

Open

2 tasks

orangejulius opened this issue Jun 13, 2016 · 0 comments

Labels

Member

orangejulius commented Jun 13, 2016 •

edited

Loading

We use nodemailer with nodemailer-ses-transport for sending emails. Because this relies on external services it's hard to test.

Ideally we would have tests, perhaps with mocks or other things that allow us to test the following:

The output of the email template is as we expect
The parameters nodemailer and nodemailer-ses-transport expect are being passed along

orangejulius added the processed label

orangejulius mentioned this issue

Update nodemailer-ses-transport to version 1.4.0 🚀 #61

Merged

orangejulius mentioned this issue

Revert to nodemailer 2.7.2 #98

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment