Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

many records incorrectly assigned to 'venue' layer #373

Open
missinglink opened this issue Nov 8, 2019 · 0 comments
Open

many records incorrectly assigned to 'venue' layer #373

missinglink opened this issue Nov 8, 2019 · 0 comments
Labels
help wanted

Comments

@missinglink
Copy link
Member

the code in layerMappingStream.js defaults to assigning the venue layer when it can't decide on which another layer to assign it.

this is problematic as a lot of random stuff is showing up in pelias when people filter by layers=venue like this.

two possible solutions (I didn't look into very deeply):

  • invert the matching so there is no default layer and we whitelist the ones we accept, reject the rest (which might be a nice way to slowly remove Geonames completely)
  • use the output of metadata/category_mapping.json to make better decisions on what should be classified as a 'venue'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@missinglink