Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set store:false for phrase fields #376

Closed
missinglink opened this issue Sep 10, 2019 · 3 comments
Closed

Set store:false for phrase fields #376

missinglink opened this issue Sep 10, 2019 · 3 comments

Comments

@missinglink
Copy link
Member

missinglink commented Sep 10, 2019

Since we disable returning the stored values of the phrase.* fields, we can probably disable store-ing any of those strings (which are duplicated in the name.* fields anyway if we want them) and save some bytes?

@orangejulius
Copy link
Member

This is probably worth trying since it's basically a one line change.

In the long run, we should solve the phrase issues with #285, but that could take a while. This change is easy to make so why not? :)

@missinglink
Copy link
Member Author

oh I think it's already set up correctly, I swear I have this same thought every 6 months 😄

fields are store:false by default, we use the _source field to get the original inputs, and phrase.* is excluded from that.

@jgmarce
Copy link

jgmarce commented Sep 15, 2019

I don't agree that the original #285 "issues" were truly an inconvenience. With a "jq" command to duplicate name.default to phrase.default elasticdump can be used as expected. I find it convenient that phrase.default is hidden at the moment, as I now add tokens there that would look odd if exposed. I imagine that phrase.default was hidden simply for aesthetic reasons. How will the addition of many, many language alternatives effect these two fields. In one way, it will be good to know if/when Pelias no longer uses the "_source.phrase" field, in which case I would only retain "phrase.default" and drop any language data from "name".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants