-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate languages for admin names #264
Comments
That make sense. I was thinking about pelias/schema#349 yesterday, and wondering how much space we would save if we were only indexing, but not storing, admin fields for autocomplete. Since Elasticsearch has to duplicate all the admin values many times, we aren't getting much "bang for our storage buck", and as we have discovered there is a performance cost to having more data in Elasticsearch: it means fewer records can fit into disk cache. If we started excluding all the admin fields from the |
One slight modification to our current behavior that might be useful. Currently, the language middleware in API defaults to English if no language is set via HTTP headers or the |
It looks like English tokens are not available in the elasticsearch admin indices for locations where the default language is not English.
For instance, the query
dionysiou areopagitou, athens
will fail with strict admin matching but succeed for the querydionysiou areopagitou, Αθήνα
.It's only by completely ignoring the admin token that the query can succeed.
Note: The language service kicks in afterwards and renders the English token, making it a little confusing to debug.
I think it's important that we start importing more aliases for the terms, which would have to be provided by
wof-admin-lookup
during PIP.Some examples:
The text was updated successfully, but these errors were encountered: