You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've recently had a problem using the plugin with image files that have whitespaces in their name. This gives no problem on the src attribute as it has no separator. However for responsive-images, the srcset attribute uses whitespaces as separator between filename and the width/pixel-density descriptor, hence images filename with whitespaces in them breaking the property parsing of the browser.
I was able to fix it by modifying the build_srcset() function.
I added a urlencoding to the filename using urllib.parse.quote(), as such
should this become a feature, and if yes it probably need to be done for the whole path including parents folder, and with a little more care than this quick edit.
The text was updated successfully, but these errors were encountered:
yes exactly! however urlencoding the original images src doesn't work because image_process rewrite it anyways, so this step has to be done in the plugin itself as far as i understand
I've recently had a problem using the plugin with image files that have whitespaces in their name. This gives no problem on the
src
attribute as it has no separator. However for responsive-images, thesrcset
attribute uses whitespaces as separator between filename and the width/pixel-density descriptor, hence images filename with whitespaces in them breaking the property parsing of the browser.I was able to fix it by modifying the
build_srcset()
function.I added a urlencoding to the filename using
urllib.parse.quote()
, as suchshould this become a feature, and if yes it probably need to be done for the whole path including parents folder, and with a little more care than this quick edit.
The text was updated successfully, but these errors were encountered: