-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use VaultIdManager
instead of specific wallet
when processing open requests
#416
Comments
@pendulum-chain/product this task is about cleaning up some code and only becomes relevant once we want to give vault operators the chance to assign different Stellar accounts for each of their supported vaults (in one vault client instance). Thus it has rather low priority IMO. |
Hey team! Please add your planning poker estimate with Zenhub @adelarja @b-yap @ebma @TorstenStueber @gianfra-t |
Not really @annatekl |
Based on the comments above moving it to icebox as very low priority, correct if wrong @ebma |
Follow-up to changes made in #385.
As pointed out in this comment, instead of passing a specific
wallet
instance we should pass an instance of theVaultIdManager
so that all wallets are available.We need to change the signature of spawn_tasks_to_execute_open_requests_async to receive a
VaultIdManager
instead of awallet
so that this logic works as expected if in the future we decide to support vault clients to use a different Stellar account per instance.The text was updated successfully, but these errors were encountered: