Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VaultIdManager instead of specific wallet when processing open requests #416

Open
ebma opened this issue Oct 11, 2023 · 6 comments
Open

Comments

@ebma
Copy link
Member

ebma commented Oct 11, 2023

Follow-up to changes made in #385.

As pointed out in this comment, instead of passing a specific wallet instance we should pass an instance of the VaultIdManager so that all wallets are available.

We need to change the signature of spawn_tasks_to_execute_open_requests_async to receive a VaultIdManager instead of a wallet so that this logic works as expected if in the future we decide to support vault clients to use a different Stellar account per instance.

@ebma
Copy link
Member Author

ebma commented Oct 11, 2023

@pendulum-chain/product this task is about cleaning up some code and only becomes relevant once we want to give vault operators the chance to assign different Stellar accounts for each of their supported vaults (in one vault client instance). Thus it has rather low priority IMO.

@prayagd
Copy link
Collaborator

prayagd commented Oct 11, 2023

@b-yap b-yap self-assigned this Oct 11, 2023
@annatekl
Copy link

@ebma @b-yap is this relevant to pick it up for the current spacewalk launch?

@ebma
Copy link
Member Author

ebma commented Dec 14, 2023

Not really @annatekl

@TorstenStueber
Copy link
Member

TorstenStueber commented Dec 16, 2023

@prayagd @annatekl Any reason this is not in Ready yet? Can we already move it there?

@prayagd
Copy link
Collaborator

prayagd commented Jan 18, 2024

Based on the comments above moving it to icebox as very low priority, correct if wrong @ebma

@b-yap b-yap removed their assignment Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants