-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-commit and pre-push hooks #525
Labels
type:chore
Maintenance tasks
Comments
@pendulum-chain/product this only improves our developer experience and doesn't add any new features. It's quite annoying though, so I'd appreciate if someone can work on this soon. |
Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber |
@annatekl adding a ongoing epic, change if not right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following up to the changes made in #513, we need to modify our pre-commit and pre-push hooks. The problem is that the pre-commit hook will run
rustfmt
using the stable toolchain (as that's the one defined in therust-toolchain.toml
file) but the check in CI performs the check using a nightly toolchain, see here.The problem with the pre-push hook is that it's not performing the same checks as we have in the workflow file anymore.
TODO
rustfmt
check to be performed by the stable toolchain in the CI or change the pre-commit hook to use the respective nightly version. We should fix this version to the same version that is used in the CI file though.The text was updated successfully, but these errors were encountered: