Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit and pre-push hooks #525

Open
ebma opened this issue May 13, 2024 · 3 comments
Open

Fix pre-commit and pre-push hooks #525

ebma opened this issue May 13, 2024 · 3 comments
Labels
type:chore Maintenance tasks

Comments

@ebma
Copy link
Member

ebma commented May 13, 2024

Following up to the changes made in #513, we need to modify our pre-commit and pre-push hooks. The problem is that the pre-commit hook will run rustfmt using the stable toolchain (as that's the one defined in the rust-toolchain.toml file) but the check in CI performs the check using a nightly toolchain, see here.

The problem with the pre-push hook is that it's not performing the same checks as we have in the workflow file anymore.

TODO

  • Either move the rustfmt check to be performed by the stable toolchain in the CI or change the pre-commit hook to use the respective nightly version. We should fix this version to the same version that is used in the CI file though.
    • Changing the hook to use the nightly toolchain is preferable because some checks are only available on the nightly version
  • Change the pre-push hook to perform similar clippy checks as the ci workflow. Here, maybe we have to cut corners and reduce it to just one of the two checks. The problem is that the check will take forever as we'd first need to compile with the stable toolchain and then with the nightly version.
@ebma ebma added the type:chore Maintenance tasks label May 13, 2024
@ebma
Copy link
Member Author

ebma commented May 13, 2024

@pendulum-chain/product this only improves our developer experience and doesn't add any new features. It's quite annoying though, so I'd appreciate if someone can work on this soon.

@prayagd
Copy link
Collaborator

prayagd commented Aug 22, 2024

@prayagd
Copy link
Collaborator

prayagd commented Aug 22, 2024

@annatekl adding a ongoing epic, change if not right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:chore Maintenance tasks
Projects
None yet
Development

No branches or pull requests

2 participants