[Django + Python] Error catching for dining dates

[judtinzhang]

As we were in a rush to fix dining menus, we left out key error catching! Here is one example. Help us verify the date and make sure it is within range (if today is Monday, then we want the date to be no further than next Sunday).

[rudyroggio]

Wouldn't something as simple as this suffice?

class Menus(generics.ListAPIView):
    """
    GET: returns list of menus, defaulted to all objects within the week,
    and can specify the filter for a particular day
    """
    serializer_class = DiningMenuSerializer

    def get_queryset(self):
        if date_param := self.kwargs.get("date"):
            date = make_aware(datetime.datetime.strptime(date_param, "%Y-%m-%d"))
            if date < timezone.now().date():
                raise Http404
            elif date > timezone.now().date() + datetime.timedelta(days=6):
                raise Http404
            return DiningMenu.objects.filter(date=date)
        else:
            start_date = timezone.now().date()
            end_date = start_date + datetime.timedelta(days=6)
            return DiningMenu.objects.filter(date__gte=start_date, date__lte=end_date)