Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validator definition with duplicate consensus key to smoke test #1210

Closed
hdevalence opened this issue Jul 22, 2022 · 1 comment · Fixed by #1643
Closed

Add validator definition with duplicate consensus key to smoke test #1210

hdevalence opened this issue Jul 22, 2022 · 1 comment · Fixed by #1643
Assignees
@conorsch

Comments

@hdevalence
Copy link
Member

Describe the solution you'd like

We should check that uploading a validator definition with a duplicate consensus key fails. To do this, we can grab the consensus key of an existing validator, insert it into a default validator definition, and upload it.

Additional context
#1207
@plaidfinch plaidfinch added this to the Testnet 23: Arche milestone Jul 22, 2022
@hdevalence
Copy link
Member Author

We should also try updating a validator definition to include someone else's consensus key

@hdevalence hdevalence removed this from the Testnet 23: Arche milestone Jul 23, 2022
@redshiftzero redshiftzero moved this to Todo in Testnets Oct 14, 2022
@erwanor erwanor moved this from Todo to Future in Testnets Nov 11, 2022
@conorsch conorsch moved this from Future to In Progress in Testnets Nov 17, 2022
@conorsch conorsch mentioned this issue Nov 17, 2022
Merged
@aubrika aubrika moved this from In Progress to Testnet 36: Iocaste in Testnets Nov 18, 2022
@erwanor erwanor closed this as completed Nov 21, 2022
Repository owner moved this from Testnet 36: Iocaste to Testnet 32: Chaldene in Testnets Nov 21, 2022
@erwanor erwanor moved this from Testnet 32: Chaldene to Testnet 36: Iocaste in Testnets Nov 21, 2022
@conorsch conorsch mentioned this issue Nov 22, 2022
Merged
@hdevalence hdevalence mentioned this issue Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorsch conorsch

Labels
None yet
Projects
No open projects
Testnets
Status: Testnet 36: Iocaste
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: validator malformed definition update fails penumbra-zone/penumbra
5 participants
@hdevalence @zbuc @plaidfinch @conorsch @erwanor