Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't forget note commitments while any proposal is open for voting #1233

Closed
plaidfinch opened this issue Jul 31, 2022 · 1 comment
Closed

Don't forget note commitments while any proposal is open for voting #1233

plaidfinch opened this issue Jul 31, 2022 · 1 comment
Assignees
@plaidfinch
Labels
A-client Area: Design and implementation for client functionality A-governance Area: Governance

Comments

@plaidfinch
Copy link
Collaborator

We don't need to do #1200, because we can instead submit a current proof for each note commitment, and check that the position was less than the proposal start block. This requires us to not forget commitments when any proposal is open for voting: eventually we want to have a table of delayed commitments to forget, and process their forgession as soon as a proposal is no longer in process of voting, but for now we can leak storage and postpone that clean-up to after the MVP for voting.
@plaidfinch plaidfinch added A-client Area: Design and implementation for client functionality A-governance Area: Governance labels Jul 31, 2022
@plaidfinch plaidfinch self-assigned this Jul 31, 2022
@plaidfinch
Copy link
Collaborator Author

This is implemented in #1795.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plaidfinch plaidfinch

Labels
A-client Area: Design and implementation for client functionality A-governance Area: Governance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plaidfinch