Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup: restore implementation of manually claiming unclaimed swaps #1753

Closed
hdevalence opened this issue Dec 12, 2022 · 0 comments · Fixed by #2965
Closed

Followup: restore implementation of manually claiming unclaimed swaps #1753

hdevalence opened this issue Dec 12, 2022 · 0 comments · Fixed by #2965
Assignees
@zbuc

Comments

@hdevalence
Copy link
Member

Followup: restore implementation of manually claiming unclaimed swaps

This is necessary if the command fails partway through for some reason. We may have to extend the view protocol to return a list of all unclaimed swaps to do so. We should also restore the hook to claim unclaimed swaps in the tx sweep implementation, which is currently commented out.

Originally posted by @hdevalence in #1736 (comment)
@avahowell avahowell moved this to Testnet 49: Pasiphae in Testnets Mar 10, 2023
@hdevalence hdevalence moved this from Testnet 49: Pasiphae to Next in Testnets Mar 16, 2023
@plaidfinch plaidfinch moved this from Next to Testnet 53: Himalia in Testnets May 5, 2023
@erwanor erwanor moved this from Testnet 53: Himalia to Next in Testnets May 19, 2023
@aubrika aubrika removed their assignment May 31, 2023
@zbuc zbuc self-assigned this Aug 29, 2023
@zbuc zbuc moved this from Next (Steal from here) to In Progress (Already claimed) in Testnets Aug 29, 2023
@zbuc zbuc mentioned this issue Sep 1, 2023
Merged
@zbuc zbuc closed this as completed in #2965 Sep 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress (Already claimed) to Testnet 60: Tethys in Testnets Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zbuc zbuc

Labels
None yet
Projects
No open projects
Testnets
Status: Testnet 60: Tethys
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable sweeping of unclaimed swaps penumbra-zone/penumbra
3 participants
@hdevalence @zbuc @aubrika