Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IBC event handling to make use of TypedEvents #2285

Closed
hdevalence opened this issue Mar 30, 2023 · 4 comments
Closed

Refactor IBC event handling to make use of TypedEvents #2285

hdevalence opened this issue Mar 30, 2023 · 4 comments
Assignees

Comments

@hdevalence
Copy link
Member

Is your feature request related to a problem? Please describe.

One of the issues we ran into while debugging compatibility between pd and rly was inconsistent encoding of event data that was intended to be picked up by the relayer. Currently, we handle events with events::named_event(...) -> Event constructors that take typed values and create events from them. However, this is still somewhat error-prone.

Describe the solution you'd like

After informalsystems/tendermint-rs#1288 lands upstream, we can define our own domain types representing the data in abci::Events. This will give us a more maintainable, single source of truth on how our event serialization should be defined.

@plaidfinch
Copy link
Collaborator

Instead of changing the types in our penumbra-ibc crate, we should try to align with the ibc-types refactoring. In other words, this should be part of the ibc-types refactoring.

@plaidfinch
Copy link
Collaborator

Blocked on IBC types refactoring.

@conorsch
Copy link
Contributor

ibc-types refactoring is complete. Unclear to me whether this is related to #2385.

@conorsch
Copy link
Contributor

conorsch commented Aug 1, 2023

Resolved in #2829

@conorsch conorsch closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Testnet 57: Ganymede
Development

No branches or pull requests

4 participants