You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
to address #3627, we tested that #3652 maintained compatibility by spinning up a live validator and connecting to it via the web wallet. this is a time-consuming process that we can't perform on every PR, so we nonetheless observed a regression after landing other seemingly innocuous changes to pd's router. (see #3697, #3679)
we should introduce some integration test coverage that demonstrates that a gRPC-web client can properly communicate with a fullnode.
i would prefer if the solution to this does not entail depending on the web repository as a submodule. perhaps we could spin up a test client that also uses the same connect-es library, to show that transport works properly.
The text was updated successfully, but these errors were encountered:
cratelyn
added
A-node
Area: System design and implementation for node software
A-CI/CD
Relates to continuous integration & deployment of Penumbra
labels
Jan 30, 2024
i don't believe so. that is discussing the web project's CI; i'd like if we had something in the penumbra monorepo to exercise this.
i'm not privy to how they are planning on wiring up playwright though, presumably it would be running against the preview network? in that case, we would still be in a position where our test suite would not catch regressions that could break the web extension until after changes have been merged.
i'd like something that, while perhaps not exhaustive, gives us some confidence that grpc-web clients can talk to pd. does that sound fair to you, @hdevalence?
Yes, the issue is just that we aren't putting any web tooling in this repo, to insulate the core protocol development from the churn of web tooling. So unless we have a Rust grpc-web client handy we'll need to get delayed notifications via a CI run triggered in another repo. I think that's fine, since those breaks should be rare — this is the first one in more than a year.
it is an important requirement of
pd
that we have maintain compatibility with gRPC-web clients. the https://github.com/penumbra-zone/web project depends uponconnect-es
to communicate with nodes via the gRPC-web protocol.to address #3627, we tested that #3652 maintained compatibility by spinning up a live validator and connecting to it via the web wallet. this is a time-consuming process that we can't perform on every PR, so we nonetheless observed a regression after landing other seemingly innocuous changes to
pd
's router. (see #3697, #3679)we should introduce some integration test coverage that demonstrates that a gRPC-web client can properly communicate with a fullnode.
i would prefer if the solution to this does not entail depending on the web repository as a submodule. perhaps we could spin up a test client that also uses the same
connect-es
library, to show that transport works properly.The text was updated successfully, but these errors were encountered: