Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brackets 1.2 deprecation warnings #13

Closed
AdriVanHoudt opened this issue Mar 2, 2015 · 8 comments
Closed

Brackets 1.2 deprecation warnings #13

AdriVanHoudt opened this issue Mar 2, 2015 · 8 comments

Comments

@AdriVanHoudt
Copy link

 Deprecated: Do not use $().on/off() on Brackets modules and model objects. Call on()/off() directly on the object without a $() wrapper.
    at new jQuery.fn.init (/brackets.js:481:36)
    at n (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/thirdparty.min.js:559:405)
    at Object.<anonymous> (file:///C:/Users/adri/AppData/Roaming/Brackets/extensions/user/peolanha.brackets-eslint/main.js:86:2)
    at Object.context.execCb (file:///C:/Program%20Files%20(x86)

Should be an easy fix

@peol
Copy link
Owner

peol commented Apr 7, 2015

I'm diverting users to https://github.com/zaggino/brackets-eslint which fills the exact same functionality and is better maintained. Thanks for your support :)

@peol peol closed this as completed Apr 7, 2015
@AdriVanHoudt
Copy link
Author

Only I can't install it via Brackets .__.

@peol
Copy link
Owner

peol commented Apr 13, 2015

If I understand @zaggino correctly, you should be able to update it through: https://github.com/zaggino/brackets-npm-registry

@AdriVanHoudt
Copy link
Author

yeah but why would I want that? Brackets has a built in registry

@zaggino
Copy link

zaggino commented Apr 13, 2015

Built-in registry can't download dependencies from npm and run build scripts, that's why brackets-npm-registry exists. brackets-eslint uses the same exact version of the eslint, which is in npm with few other dependencies. It's not possible to upload these dependencies to built-in registry due to its restrictions.

@AdriVanHoudt
Copy link
Author

hmm I see, is this an issue that Brackets owners/contributors are aware of?

@zaggino
Copy link

zaggino commented Apr 13, 2015

Yes, I've also opened a PR with a lighter version of this (downloads dependencies, but can't run build scripts) for a default registry (adobe/brackets#10602).

@AdriVanHoudt
Copy link
Author

@zaggino nice, might want to bump the PR with a reaction on @nethip's questions or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants