Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null subsample tables in peppy.Project #393

Closed
nleroy917 opened this issue Aug 15, 2022 · 1 comment · Fixed by #489
Closed

Allow null subsample tables in peppy.Project #393

nleroy917 opened this issue Aug 15, 2022 · 1 comment · Fixed by #489

Comments

@nleroy917
Copy link
Member

I was attempting to create a new peppy.Project object with the following config:

name: GSE96155
pep_version: 2.1.0
sample_table: GSE96155_annotation.csv
subsample_table: null
...

And peppy threw the following error: TypeError: Provided argument has to be a List[str] or a str, got 'NoneType'

Based on the discussion over at geofetch: pepkit/geofetch#80, peppy should allow null sub sample tables.

@nleroy917 nleroy917 added the bug label Aug 15, 2022
@nleroy917
Copy link
Member Author

Low priority, but just saying this still exists as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants