Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command that takes screenshots and writes them to a file instead of uploading #1596

Open
jmuzina opened this issue May 13, 2024 · 1 comment
Labels
✨ enhancement New feature or request

Comments

@jmuzina
Copy link

jmuzina commented May 13, 2024

Similar issue: #1327

It would be nice if the CLI offered a new command (or perhaps a flag on percy snapshot) that saves the Percy snapshot artifacts into a local directory rather than uploading them. These artifacts could be stored serialized or as png/jpg files etc.

A potential use case for this feature is enabling public repositories to use Percy in their fork PR checks. As percy snapshot requires a Percy token secret, public repos cannot use Percy CLI to take snapshots without allowing contributors to write to their repository directly (GH actions does not expose repository secrets to forks on pull_request triggers). With this change, public repos could have a fork pull_request action take percy snapshots and archive them as a build artifact, enabling the base repo to call percy upload on those screenshot artifacts.

@ninadbstack
Copy link
Contributor

We will take this as a feature request and get back to you. There is no ETA for this as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants