Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[percy:cli] Error: Finalizing build # failed: cannot finalize before all snapshot resources are uploaded. #1716

Closed
unlikelyzero opened this issue Sep 10, 2024 · 3 comments

Comments

@unlikelyzero
Copy link

The problem

Build is failing due to a timing issue in percy cli nasa/openmct#7829

Environment

"@percy/cli": "1.27.4",
"@percy/playwright": "1.0.4",

Details

It looks like a failed network response from the percy server.

Debug logs

[percy:core:browser] Closing browser (783ms)
[percy:core:browser] Browser closed (23ms)
[percy:client] Finalizing build 36306715... (0ms)
[percy:cli] Error: Finalizing build 36306715 failed: cannot finalize before all snapshot resources are uploaded. This is likely a client error, please make sure that content for all SHAs in 'missing-resources' from the snapshot response are uploaded before calling finalize.
at handleFinished (file:///root/project/e2e/node_modules/@percy/client/dist/utils.js:186:17)
at IncomingMessage. (file:///root/project/e2e/node_modules/@percy/client/dist/utils.js:202:27)
at IncomingMessage.emit (node:events:531:35)
at endReadableNT (node:internal/streams/readable:1696:12)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) (182ms)

Code to reproduce issue

Everything we do is open source and can be seen here https://app.circleci.com/pipelines/github/nasa/openmct/23591/workflows/88c419fb-2dcf-4f80-a3cf-4a6217042330/jobs/103331

@prklm10
Copy link
Contributor

prklm10 commented Sep 16, 2024

@unlikelyzero we are checking this. Thanks for raising the issue.

@prklm10
Copy link
Contributor

prklm10 commented Sep 18, 2024

@unlikelyzero can you try few things ->

  • Please update the percy cli version to the latest.
  • Can you add concurrency: 2 in you percy.yml file docs
  • Can you try above stuff and revert back to us if you are seeing this issue is still persistent or not.

@ninadbstack
Copy link
Contributor

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants