Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent @percy/sdk-utils change breaks AMD import #610

Closed
dfreeman opened this issue Jul 28, 2022 · 2 comments
Closed

Recent @percy/sdk-utils change breaks AMD import #610

dfreeman opened this issue Jul 28, 2022 · 2 comments

Comments

@dfreeman
Copy link
Contributor

The problem

Starting 2 days ago, our nightly "forget the lockfile and see what happens" compatibility tests for our design system package started failing due to test loader errors. I've tracked it down to @percy/ember failing to load @percy/sdk-utils due to the change that landed in percy/cli#1000

the Chrome debugger paused while attempting to call the string '@percy/sdk-utils' as a function

Environment

  • Node version: 16.15.0
  • @percy/cli version: 1.6.4

Code to reproduce issue

This should be reproducible in this repo by refreshing the @percy/sdk-utils entry in the lockfile here.
@wwilsman wwilsman mentioned this issue Jul 28, 2022
Merged
@wwilsman
Copy link
Contributor

wwilsman commented Jul 28, 2022 •
edited
Loading

Hey @dfreeman!

Can you give @percy/ember v3.0.1 a try? 🤞

@dfreeman
Copy link
Contributor Author

That looks like it did the trick—thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfreeman @wwilsman