Exit code is 0 when snapshot limit is exceeded

[bernardobelchior]

The problem

When running PERCY_TOKEN=<token> npx percy storybook ./storybook-static and the snapshot limit has been reached, the CLI does not return a non-zero exit code. When using in CI, it means CI won't fail and will instead pass even though tests could be failing.

This happens both in my local mac as well as on CI (GH Actions running on ubuntu-latest).

Environment

• Node version: v18.16.0 (or v16 for GH Actions)
• @percy/cli version: 1.24.0
• Version of Percy SDK you’re using: 4.3.6
• If needed, a build or snapshot ID: N/A
• OS version: macOS 13.3.1; Ubuntu (ubuntu-latest from GH Actions)
• Type of shell command-line [interface]: zsh on macOS; Our CI is GitHub Actions running on ubuntu-latest.

Details

$ PERCY_TOKEN=<token> npx percy storybook ./storybook-static
[percy] Percy has started!
  <truncated for brevity>
[percy] Failed to create build
[percy] Error: This organization has exceeded the limits of the Percy BrowserStack plan plan. Administrators can upgrade here: https://percy.io/organizations/<censored>/billing
[percy] Build not created

$ echo $?
0

Debug logs

See above

Code to reproduce issue

N/A

[samarsault]

Thanks for reaching out. We already have this on our roadmap and will be adding this soon

[bernardobelchior]

Thank you, @samarsault 🙏