-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor shared code between latency and latencybg tests #1450
Comments
Semi-related: #994 |
The plan for this should be:
|
Currently the latency and latencybg tests have a lot of copy and pasted code between them which make it challenging when you need to do updates since you have to do it in two place. Its made worse by the fact that its clearly copy and pasted but file structures and such don't even match, so its "just close enough to be annoying". For example, the result formatting is almost exactly the same even though each test has its own independent copy. Recently we fixed how bucket width is handled in latency and that did not make its way to latencybg since it was separate even though the code is similar.
We should give them some proper shared libraries between them for code like this. They are legitimately different tests, but for the common bits we should only need to update code in one place.
The text was updated successfully, but these errors were encountered: