NumericEval: fix typo on error handling

rehsack · rehsack · commit af13adb1f489 · 2016-07-08T10:49:53.000+02:00
Sandy_Bio_Perl figured out a bug while using DBD::CSV which has been proven by Tux (Merjin) as a real bug in SQL::Statement. http://www.perlmonks.org/?node_id=1167381 Thanks to both! Signed-off-by: Jens Rehsack <sno@netbsd.org>
diff --git a/lib/SQL/Statement/Function.pm b/lib/SQL/Statement/Function.pm
@@ -223,7 +223,7 @@ sub value($)
       map { _INSTANCE( $_, 'SQL::Statement::Term' ) ? $_->value($eval) : $_ } @{ $self->{PARAMS} };
     foreach my $val (@vals)
     {
-        return $self->do_err(qq~Bad numeric expression '$val'!~)
+        return $owner->do_err(qq~Bad numeric expression '$val'!~)
           unless ( defined( _NUMBER($val) ) );
     }
     $expr =~ s/\?(\d+)\?/$vals[$1]/g;

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ sub value($)`
`223`	`223`	`map { _INSTANCE( $_, 'SQL::Statement::Term' ) ? $_->value($eval) : $_ } @{ $self->{PARAMS} };`
`224`	`224`	`foreach my $val (@vals)`
`225`	`225`	`{`
`226`		`- return $self->do_err(qq~Bad numeric expression '$val'!~)`
	`226`	`+ return $owner->do_err(qq~Bad numeric expression '$val'!~)`
`227`	`227`	`unless ( defined( _NUMBER($val) ) );`
`228`	`228`	`}`
`229`	`229`	`$expr =~ s/\?(\d+)\?/$vals[$1]/g;`