Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatpacked version missing File::Share #4

Open
polettix opened this issue Jun 24, 2019 · 3 comments
Open

Fatpacked version missing File::Share #4

polettix opened this issue Jun 24, 2019 · 3 comments

Comments

@polettix
Copy link

The fatpacked version in branch standalone is missing File::Share. It seems to be used in two places.

@perlpunk
Copy link
Owner

Thanks!
It seems to be working though.
The only command I know isn't working is appspec validate.
I think the problem is that File::Share (or File::ShareDir) wouldn't really work with fatpack.
But I think I can fix that by replacing this code:
https://github.com/perlpunk/App-AppSpec-p5/blob/master/lib/App/AppSpec/Schema/Validator.pm#L23
I would put the schema into a module as a hashref instead of loading it from a file.

Or maybe I can get File::Share working; I only used fatpack for this project and don't know enough about it yet.

@polettix
Copy link
Author

Now that you tell me, I was actually trying to use validate on a YAML input file, before running it for completion. I just installed File::Share in a local lib and re-run it though, I didn't know I could do without :)

@perlpunk
Copy link
Owner

perlpunk commented Jul 6, 2019

The latest version does not need File::Share anymore, however, it needs JSON::Validator, which is not packed into the standalone version.
I have to figure out how to explicitly add it.
But at least the error message should be less confusing now ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants