Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove directory under /italia #3799

Closed
bfabio opened this issue Dec 21, 2023 · 5 comments
Closed

Remove directory under /italia #3799

bfabio opened this issue Dec 21, 2023 · 5 comments

Comments

@bfabio
Copy link
Contributor

bfabio commented Dec 21, 2023

Hello, the directory created with #3636 should be removed, as it was not vetted by the contacts listed in the readme.md where the new directory was placed.

@dgarijo
Copy link
Collaborator

dgarijo commented Dec 21, 2023

You are right, I have given them until 27/12 to provide an alternate parent folder or I will move them to the root parent folder.

@bfabio
Copy link
Contributor Author

bfabio commented Dec 21, 2023

@dgarijo thank you 🙌 I appreciate your work

I'm thinking of a GitHub workflow / action to check anomalies like those, which can maybe help highlight them right away in the PR. Would that be helpful and would you be willing to include it?

@dgarijo
Copy link
Collaborator

dgarijo commented Dec 21, 2023

It's tricky since in some cases people don't add their github ids, or there are other people doing PRs on behalf of other people. In any case, up to @davidlehn to assess. From my end, it would be great to have some extra help

@bfabio
Copy link
Contributor Author

bfabio commented Dec 22, 2023

The idea is to check just italia/ for now as we know we'll always add the maintainers' usernames in the readme files for each subdirectory, if they're supposed to be managed by a different entity.

I don't expect it to fully replace your valuable review of course, but at least it can be a layer of protection.

If that works out well, owners of other paths might be interested in using the system as well and adapting their readme. We could even come up with a machine readable microformat to specify the username.

Let's do a PoC and see how it goes.

About this directory, maybe the best thing to do here is to revert that commit: they don't need or want a top-level dir and they will provide a new fixed PR to place a different directory under italia/ anyway

@bfabio
Copy link
Contributor Author

bfabio commented Jan 12, 2024

Closing this one as it was resolved by #3805. Thanks @dgarijo

@bfabio bfabio closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants