Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds back missing CONSTRAINED trajectory tag. #191

Merged
merged 2 commits into from
Sep 24, 2015

Conversation

psigen
Copy link
Member

@psigen psigen commented Sep 24, 2015

For some reason, the CONSTRAINED trajectory tag was lost during the vectorfield refactor. This PR adds it back.

For some reason, the CONSTRAINED trajectory tag was lost during the vectorfield refactor.
@mkoval
Copy link
Member

mkoval commented Sep 24, 2015

We've determined that using the time information from the integration is a bad idea. It's generated using s first order approximation, so the result isn't pretty when you try to execute it with real dynamics. Can you remove that comment?

Also, shouldn't we flag the output as smooth? The waypoints are quite sense, so it should be safe to simply interpolate between them.

@psigen
Copy link
Member Author

psigen commented Sep 24, 2015

I don't know? I don't know what the difference between SMOOTH and CONSTRAIN is intended to be,

I thought SMOOTH required valid timing but there's no comments on any of them so I just put whatever was there before.

@mkoval mkoval added the bug label Sep 24, 2015
@mkoval
Copy link
Member

mkoval commented Sep 24, 2015

SMOOTH was intended to mean that the waypoints are close enough together that you can approximate derivatives at the waypoints using divided differences. I.e. we can safely fit a spline without collision checking.

mkoval added a commit that referenced this pull request Sep 24, 2015
Added missing trajectory flags to VectorFieldPlanner.
@mkoval mkoval merged commit 8d308d8 into master Sep 24, 2015
@mkoval mkoval deleted the bugfix/vector_field_tags branch September 24, 2015 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants