Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to get a list of named configurations #271

Merged
merged 1 commit into from
Feb 25, 2016

Conversation

jeking04
Copy link
Contributor

This pull request allows you to get a list of known configurations via:

named_configs = robot.configurations.get_configuration_list()

@psigen
Copy link
Member

psigen commented Feb 25, 2016

It seems to me that configurations and tsrs sound like they should be list-like or dict-like, and it is really counter-intuitive for them to have completely custom APIs. Having a call like robot.configurations.get_configuration_list() really seems awkward and not what I would expect to have to do.

But I don't really use this API much, so I'll leave those decisions to you guys.

@mkoval
Copy link
Member

mkoval commented Feb 25, 2016

@psigen I posted a justification for the ConfigurationLibrary class in personalrobotics/herbpy#81. As always, I'm welcome to hear a compelling counter-argument. 😄

mkoval added a commit that referenced this pull request Feb 25, 2016
Adding ability to get a list of named configurations.
@mkoval mkoval merged commit 1be805c into master Feb 25, 2016
@mkoval mkoval deleted the feature/named_config_list branch February 25, 2016 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants