Skip to content
This repository has been archived by the owner on Nov 12, 2021. It is now read-only.

Extract and log transaction failure reason #51

Open
matthiasgeihs opened this issue Nov 6, 2020 · 2 comments
Open

Extract and log transaction failure reason #51

matthiasgeihs opened this issue Nov 6, 2020 · 2 comments

Comments

@matthiasgeihs
Copy link
Contributor

The operator tracks the status of challenge response transactions and logs an error if a transaction fails. Currently we do not log the failure reason because it is unclear how failure information can be extracted from go-ethereum.

Ideally we would like to log an error with the error reason (e.g., "out of gas") if a challenge response transaction fails.

@sebastianst
Copy link
Contributor

Not sure if this will also cover "out of gas", but #54 should cover other revert reasons.

@ggwpez
Copy link
Contributor

ggwpez commented Dec 7, 2020

Not sure if this will also cover "out of gas", but #54 should cover other revert reasons.

In most cases it should detect an "out of gas" error but since ethereum has no canonical way of detecting this, there are some cases where it will return with a generic reason.

#62 addresses this, i will link it in #54.

@ggwpez ggwpez linked a pull request Dec 7, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants