Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reliance on SHA1 library causes dependents to be flagged as unsafe #763

Closed
jeramyRR opened this issue Jan 6, 2023 · 1 comment
Closed

Reliance on SHA1 library causes dependents to be flagged as unsafe #763

jeramyRR opened this issue Jan 6, 2023 · 1 comment

Comments

@jeramyRR
Copy link
Contributor

jeramyRR commented Jan 6, 2023

Even though SHA1 is only used in meta/build.rs, it's causing dependent projects to be flagged in some build systems as unsafe to use. I'm happy to submit a PR to switch out SHA1 for SHA2, or whatever preferred algorithm, but I'm not sure completely about when and where the file hash comes in to play.

Please see https://sha-mbles.github.io/ for more information on why SHA1 is no longer considered safe to use.
@jeramyRR jeramyRR mentioned this issue Jan 6, 2023
Merged
@tomtau
Copy link
Contributor

tomtau commented Jan 7, 2023

fixed in #764

@tomtau tomtau closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeramyRR @tomtau