Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5 basic type provider. PHPUnits TestCase type for $this in PEST lambdas #11

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

adelf
Copy link
Contributor

@adelf adelf commented Jul 1, 2020

No description provided.

Copy link
Collaborator

@olivernybroe olivernybroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Awesome work, will merge this in as it's really nice for basic of autocompletion


@Override
public char getKey() {
return '\u0221';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this and why this value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some key for this provider. It is important if provider has overridden getBySignature method.

@olivernybroe olivernybroe merged commit 77d3126 into JetBrains:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants