Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Settings::reconverge with Option<u32> to indicate the ID of reconverge for the applicable node #291

Open
minshao opened this issue Jun 12, 2024 · 0 comments
Labels
blocked Pending another issue

Comments

@minshao
Copy link
Contributor

minshao commented Jun 12, 2024

After the removal #273, the only field related to REconverge in the Settings would be a boolean flag indicate whether the node contains reconverge.

  • In the future, it would be more informative to keep something similar to Option<u32>, where the u32 indicates the id of reconverge.
  • Reconverge id would be available once we completed setting up profile storage for REconverge instance.

Blocked: currently, REconverge profile is not stored in review-database and, thus, REconverge instance doesn't have an ID yet.

@minshao minshao added the blocked Pending another issue label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Pending another issue
Projects
None yet
Development

No branches or pull requests

1 participant