No Sidekiq::Testing.inline!

[Bhacaz]

Detect offense on Sidekiq::Testing.inline! in spec and suggest to use spy/stub to manually perform specific worker that need to be run.

expect(::HospitalBooking::DeliveryWorker).to receive(:perform_at).exactly(3) do |_time, delivery_id|
  ::HospitalBooking::DeliveryWorker.new.perform delivery_id
end

Using Sidekiq::Testing.inline! can trigger many workers that are not necessary for a specific spec, like model callback using FactoryBot.create, ...

The nightmare scenario is this: user puts Sidekiq jobs into ActiveRecord callbacks, then uses something like factory_girl and creates hundreds of records and thus sidekiq jobs on every test. There is no feedback that tons of Sidekiq jobs are being executed besides the tests being slow. Now the user's unit tests take minutes to complete.
sidekiq/sidekiq#3495