Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipleExpectations could autocorrect with aggregate_failures: true #59

Closed
Bhacaz opened this issue Aug 22, 2023 · 1 comment · Fixed by #74
Closed

MultipleExpectations could autocorrect with aggregate_failures: true #59

Bhacaz opened this issue Aug 22, 2023 · 1 comment · Fixed by #74
Labels
config enhancement New feature or request

Comments

@Bhacaz
Copy link
Collaborator

Bhacaz commented Aug 22, 2023

Multiple expect could be a good practice in some cases for many reason. The MultipleExpectations cop is disable. There should be an option to autocorrect the offense by adding aggregate_failures: true.

With that autocorrect, the cop should be Enable.

https://rspec.rubystyle.guide/#expectation-per-example
https://www.betterspecs.org/#single

https://github.com/petalmd/rubocop-petal/blob/main/config/base.yml#L68

@Bhacaz Bhacaz added the config label Aug 22, 2023
@Bhacaz Bhacaz changed the title MultipleExpectations config aggregate_failures: true MultipleExpectations could autocorrect with aggregate_failures: true Aug 22, 2023
@Bhacaz Bhacaz added the enhancement New feature or request label Aug 22, 2023
@Bhacaz
Copy link
Collaborator Author

Bhacaz commented Nov 8, 2023

I think https://test-prof.evilmartians.io/misc/rubocop would help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant