Are all these MD5 tests really necessary?

[pete4abw]

HAS_MD5, NO_MD5, a confusing mish mash of code.

include/lrzip_private.h:260:#define NO_MD5              (!(HASH_CHECK) && !(HAS_MD5))
include/lrzip_private.h:334:#define HAS_MD5             (control->flags & FLAG_MD5)
lrzip.c:155:    if (!NO_MD5)
lrzip.c:1113:   if (ofs >= infile_size - (HAS_MD5 ? MD5_DIGEST_SIZE : 0))
lrzip.c:1233:   if (HAS_MD5) {
lrzip.c:1537:   if (NO_MD5)
lrzip.c:1539:   if (HAS_MD5)
runzip.c:175:   if (!HAS_MD5)
runzip.c:178:   if (!NO_MD5)
runzip.c:241:           if (!HAS_MD5)
runzip.c:244:           if (!NO_MD5)
runzip.c:376:   if (!HAS_MD5) {
runzip.c:410:   if (!NO_MD5) {
runzip.c:456:   if (!NO_MD5) {
runzip.c:460:           if (HAS_MD5) {
runzip.c:518:                   if (!HAS_MD5)
rzip.c:588:     if (!NO_MD5)
rzip.c:758:                     if (!NO_MD5)
rzip.c:765:             if (!NO_MD5)
rzip.c:962:     if (!NO_MD5) {
rzip.c:1211:    if (!NO_MD5) {

Not sure how this ever made it into the code. Maybe it had to do with the 2011 note about Apple not supporting MD5.

In advance of allowing user-selected hashing, the question arises: Is hashing necessary at all? The backend compression algos all report errors when a chunk can't be decompressed. The first step is to make hashing a default and get rid of all this cruft code. Then, we can decide if hashing is needed at all.

Thoughts?

[pete4abw]

This has been fixed and new hash methods have been introduced. See the what's next branch for implementation.