Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling for API error. #138

Closed
Ferada opened this issue Dec 3, 2014 · 4 comments
Closed

Error handling for API error. #138

Ferada opened this issue Dec 3, 2014 · 4 comments

Comments

@Ferada
Copy link
Contributor

Ferada commented Dec 3, 2014

I've just encountered an error from DigitalOcean which results in a rather large HTML dump in the console, see this gist.
@petems
Copy link
Owner

petems commented Dec 3, 2014

Interesting, we probably need to losen the error check there...

Can you run the command:

DEBUG=2 tugboat ssh -e my-host

@Ferada
Copy link
Contributor Author

Ferada commented Dec 3, 2014

I think they already recovered from that, at the moment it's just an empty result; if it comes up again I'll do that. I mean it's not a regular error, the site showed the fail-whale.

@petems
Copy link
Owner

petems commented Dec 3, 2014

Great, looks like a temporary blip and it showed a Cloudflare error.

It looks like we should handle if the API returns non-JSON better 👍

@petems petems mentioned this issue Dec 3, 2014
Merged
@petems
Copy link
Owner

petems commented Jan 29, 2015

Resolved HTML error responses in #139, closing.

@petems petems closed this as completed Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ferada @petems