Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting MRI 1.8.7 #20

Closed
blom opened this issue Apr 25, 2013 · 2 comments · Fixed by #22
Closed

Supporting MRI 1.8.7 #20

blom opened this issue Apr 25, 2013 · 2 comments · Fixed by #22

Comments

@blom
Copy link
Collaborator

blom commented Apr 25, 2013

What do you think about supporting MRI 1.8.7, and testing against it on Travis? The tests already pass on 1.8.7. It is EOL in June and all, but plenty of people will use it for some time to come. We would just need to do something about the debugger development dependency as it won't install on < 1.9.2. We could remove it from the gemspec, or move it to the Gemfile and use :platforms.
@pearkes
Copy link
Collaborator

pearkes commented Apr 25, 2013

I think it'd be great to support. Happy to give up debugger in the gemspec to make it happen. I don't know if it's best practice to have it in there if it's not actually in the code, also.

@blom
Copy link
Collaborator Author

blom commented Apr 25, 2013

Sounds good. Let me know if you want it moved to the Gemfile too.

@blom blom mentioned this issue Apr 25, 2013
Merged
@blom blom closed this as completed in 8885bc1 Apr 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support MRI 1.8.7 blom/tugboat
2 participants
@blom @pearkes